SuccessChanges

Summary

  1. Sets synchronous loading for DOJO on index page. (commit: d4c1e0f) (details)
  2. do not re-request the tree when folding/unfolding it (commit: 7e7f5f6) (details)
  3. avoid little flickering of tree when loading. (commit: 8e11e91) (details)
  4. make tree loading feel faster. (commit: 25c0fd9) (details)
  5. adds cursor:pointer on clickable element (commit: 9622862) (details)
  6. remove outline on focused element (commit: d0e533a) (details)
  7. adds cursor:pointer on clickable element (commit: 7587210) (details)
  8. reduce the default effect time from 200ms to 50ms (commit: d5d29ca) (details)
  9. fix annoying bug when clicking too fast in the tree. (commit: 203d9a7) (details)
  10. reuse dijit's getTreePath to compute the path (commit: f2c12b3) (details)
Commit d4c1e0f0ff25c8d40fa6d59ee96fa0f45735636f by Anthony Pessy
Sets synchronous loading for DOJO on index page.

It may be "slower" to load (although I don't think you can really see the difference on this application) but the fact that it was loaded asynchronously make a really annoying flickering.

And the bigger problem of this flickering is that even if you hide the administration tab, you would have time to see all its content  before DOJO load (discover, reload, etc...)
(commit: d4c1e0f)
The file was modifiedweb/index.html (diff)
Commit 7e7f5f61bd3b24e216d33334b12e5af5eea4e149 by Anthony Pessy
do not re-request the tree when folding/unfolding it

There is no need to refresh the content of the tree since we have all of it so let's just expand/collapse.

Avoid strange "closing everything", "loosing content", "trying to reopen everyone" effect.
(commit: 7e7f5f6)
The file was modifiedweb/index.html (diff)
The file was modifiedweb/lib/jrds.js (diff)
Commit 8e11e91c19f72b30d34a733bfd9bf4aca5bd35bd by Anthony Pessy
avoid little flickering of tree when loading.

Because we hide the tree's root, dojo displays a little clock to indicate that we are currently loading the content but we have already a "loading" overlay on top of all the tree and because we already have content it makes everything flickers.

There is no way in JS to avoid the display of this image so let's force the display: none and no image to avoid downloading it for nothing.
(commit: 8e11e91)
The file was modifiedweb/lib/jrds.css (diff)
Commit 25c0fd93093786dcd7d26cddad6db6e8e0b2dae6 by Anthony Pessy
make tree loading feel faster.

The standBy loading spinner has a fadeIn/fadeOut effect duration of 500ms. This is awfully long considering the time the requests take.

Let's remove this duration because we want an UI that feels responsive and that is practical. We don't really care about CSS effects that slows everything down.

Also recycle the standBy widget, not sure why it was destroyed/recreated, maybe I overlooked something.
(commit: 25c0fd9)
The file was modifiedweb/lib/jrds.js (diff)
Commit 9622862e234c9451fbd3e755837c0c4e4f427d05 by Anthony Pessy
adds cursor:pointer on clickable element

That way we indicate to the user that he can click this element.
(commit: 9622862)
The file was modifiedweb/lib/jrds.css (diff)
Commit d0e533a124c52bda6d05b7213466b98732c20f11 by Anthony Pessy
remove outline on focused element

It serve no real purpose on this site and make it weird to have a big grey border appears randomly when navigating the tree
(commit: d0e533a)
The file was modifiedweb/lib/jrds.css (diff)
Commit 75872107f184c403a96a84b9b632f2f8ca8619a4 by Anthony Pessy
adds cursor:pointer on clickable element

It is in fact the whole row that is clickable, not simply the label.
(commit: 7587210)
The file was modifiedweb/lib/jrds.css (diff)
Commit d5d29ca26d07fe249344a1b45ed21553d16a4dba by Anthony Pessy
reduce the default effect time from 200ms to 50ms

It doesn't bring much to have nice and long css animation when you have to wait after them
(commit: d5d29ca)
The file was modifiedweb/index.html (diff)
Commit 203d9a7708b0ba6a0f98ceed2059719ef60d06f2 by Anthony Pessy
fix annoying bug when clicking too fast in the tree.

When you click too fast in the tree, the node would open (with animation), close itself (instantaneously) then reopen itself (with animation).

Or the other way around.
(commit: 203d9a7)
The file was modifiedweb/lib/jrds.js (diff)
Commit f2c12b3d00d1b041e3ea85dc593b6393d9af2a06 by Anthony Pessy
reuse dijit's getTreePath to compute the path
(commit: f2c12b3)
The file was modifiedweb/lib/jrds.js (diff)